Common: Sign extend w/func not chained casts.

Should be clearer to read and easier to get right.
This commit is contained in:
Unknown W. Brackets
2021-01-31 01:25:52 -08:00
parent 8205f9b6f2
commit 1b00da2f3a
23 changed files with 92 additions and 60 deletions
+2 -1
View File
@@ -21,6 +21,7 @@
#include "zlib.h"
#include "Common/Data/Convert/SmallDataConvert.h"
#include "Common/Serialize/Serializer.h"
#include "Common/Serialize/SerializeFuncs.h"
#include "Common/Serialize/SerializeSet.h"
@@ -625,7 +626,7 @@ static void WriteVarSymbol(WriteVarSymbolState &state, u32 exportAddress, u32 re
case R_MIPS_LO16:
{
// Sign extend the existing low value (e.g. from addiu.)
const u32 offsetLo = (s32)(s16)(u16)(relocData & 0xFFFF);
const u32 offsetLo = SignExtend16To32(relocData);
u32 full = exportAddress;
// This is only used in the error case (no hi/wrong hi.)
if (!reverse) {