mirror of
https://github.com/hrydgard/ppsspp.git
synced 2026-11-16 02:59:49 +01:00
GPU: Clear alpha more consistently from 565.
Before, the backends all did different things. Now they are more in sync, but Vulkan still behaves slightly differently. Fixes #11326.
This commit is contained in:
1 parent
22a536fb0c
commit
16d7a80980
6 files changed
+65
-26
No files matched your search
@@ -364,16 +364,16 @@ void FramebufferManagerVulkan::ReformatFramebufferFrom(VirtualFramebuffer *vfb,
|
||||
// Technically, we should at this point re-interpret the bytes of the old format to the new.
|
||||
// That might get tricky, and could cause unnecessary slowness in some games.
|
||||
// For now, we just clear alpha/stencil from 565, which fixes shadow issues in Kingdom Hearts.
|
||||
// (it uses 565 to write zeros to the buffer, than 4444 to actually render the shadow.)
|
||||
// (it uses 565 to write zeros to the buffer, then 4444 to actually render the shadow.)
|
||||
//
|
||||
// The best way to do this may ultimately be to create a new FBO (combine with any resize?)
|
||||
// and blit with a shader to that, then replace the FBO on vfb. Stencil would still be complex
|
||||
// to exactly reproduce in 4444 and 8888 formats.
|
||||
|
||||
if (old == GE_FORMAT_565) {
|
||||
draw_->BindFramebufferAsRenderTarget(vfb->fbo, { Draw::RPAction::CLEAR, Draw::RPAction::CLEAR, Draw::RPAction::CLEAR });
|
||||
} else {
|
||||
draw_->BindFramebufferAsRenderTarget(vfb->fbo, { Draw::RPAction::KEEP, Draw::RPAction::KEEP, Draw::RPAction::KEEP });
|
||||
// TODO: To match other backends, would be ideal to clear alpha only and not color.
|
||||
// But probably doesn't matter that much...
|
||||
draw_->BindFramebufferAsRenderTarget(vfb->fbo, { Draw::RPAction::CLEAR, Draw::RPAction::KEEP, Draw::RPAction::CLEAR });
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user