Rework InstallZipScreen to work in portrait

This commit is contained in:
Henrik Rydgård committed 2025-11-23 21:24:29 +01:00
1 parent 3c6429a922
commit 0cab218877
51 files changed
+227 -131

No files matched your search

+168 -122
View File
@@ -33,34 +33,88 @@
#include "UI/SavedataScreen.h"
#include "UI/EmuScreen.h"
InstallZipScreen::InstallZipScreen(const Path &zipPath) : zipPath_(zipPath) {
InstallZipScreen::InstallZipScreen(const Path &zipPath) : UITwoPaneBaseDialogScreen(Path(), TwoPaneFlags::SettingsToTheRight | TwoPaneFlags::ContentsCanScroll), zipPath_(zipPath) {
g_GameManager.ResetInstallError();
struct zip *zipFile = ZipOpenPath(zipPath_);
if (zipFile) {
DetectZipFileContents(zipFile, &zipFileInfo_); // Even if this fails, it sets zipInfo->contents.
ZipClose(zipFile);
}
}
void InstallZipScreen::CreateViews() {
using namespace UI;
std::string_view InstallZipScreen::GetTitle() const {
auto iz = GetI18NCategory(I18NCat::INSTALLZIP);
return iz->T("ZIP file");
}
File::FileInfo fileInfo;
File::GetFileInfo(zipPath_, &fileInfo);
void InstallZipScreen::CreateSettingsViews(UI::ViewGroup *parent) {
using namespace UI;
auto di = GetI18NCategory(I18NCat::DIALOG);
auto iz = GetI18NCategory(I18NCat::INSTALLZIP);
auto er = GetI18NCategory(I18NCat::ERRORS);
auto ga = GetI18NCategory(I18NCat::GAME);
Margins actionMenuMargins(0, 100, 15, 0);
std::string shortFilename = zipPath_.GetFilename();
root_ = new LinearLayout(ORIENT_HORIZONTAL);
bool showDeleteCheckbox = false;
returnToHomebrew_ = false;
installChoice_ = nullptr;
playChoice_ = nullptr;
doneView_ = nullptr;
existingSaveView_ = nullptr;
ViewGroup *leftColumn = new LinearLayout(ORIENT_VERTICAL, new LinearLayoutParams(1.0f, Margins(12)));
ViewGroup *rightColumnItems = new LinearLayout(ORIENT_VERTICAL, new LinearLayoutParams(300, FILL_PARENT, actionMenuMargins));
root_->Add(leftColumn);
root_->Add(rightColumnItems);
std::vector<Path> destOptions;
switch (zipFileInfo_.contents) {
case ZipFileContents::ISO_FILE:
case ZipFileContents::PSP_GAME_DIR:
installChoice_ = parent->Add(new Choice(iz->T("Install"), ImageID("I_FOLDER_UPLOAD")));
installChoice_->OnClick.Handle(this, &InstallZipScreen::OnInstall);
// NOTE: We detect PBP isos (like demos) as game dirs currently. Can't play them directly.
if (zipFileInfo_.contents == ZipFileContents::ISO_FILE) {
playChoice_ = parent->Add(new Choice(ga->T("Play"), ImageID("I_PLAY")));
playChoice_->OnClick.Handle(this, &InstallZipScreen::OnPlay);
}
returnToHomebrew_ = true;
showDeleteCheckbox = true;
break;
case ZipFileContents::TEXTURE_PACK:
case ZipFileContents::SAVE_DATA:
installChoice_ = parent->Add(new Choice(iz->T("Install"), ImageID("I_FOLDER_UPLOAD")));
installChoice_->OnClick.Handle(this, &InstallZipScreen::OnInstall);
showDeleteCheckbox = true;
break;
case ZipFileContents::FRAME_DUMP:
// It's a frame dump, add a play button!
playChoice_ = parent->Add(new Choice(ga->T("Play"), ImageID("I_PLAY")));
playChoice_->OnClick.Handle(this, &InstallZipScreen::OnPlay);
break;
default:
// Nothing to do!
break;
}
if (showDeleteCheckbox) {
parent->Add(new Spacer(12.0f));
parent->Add(new CheckBox(&deleteZipFile_, iz->T("Delete ZIP file")));
}
}
void InstallZipScreen::CreateContentViews(UI::ViewGroup *parent) {
using namespace UI;
LinearLayout *leftColumn = parent->Add(new LinearLayout(ORIENT_VERTICAL, new LinearLayoutParams(FILL_PARENT, WRAP_CONTENT)));
auto di = GetI18NCategory(I18NCat::DIALOG);
auto iz = GetI18NCategory(I18NCat::INSTALLZIP);
auto er = GetI18NCategory(I18NCat::ERRORS);
auto ga = GetI18NCategory(I18NCat::GAME);
std::string shortFilename = zipPath_.GetFilename();
// TODO: Do in the background?
struct zip *zipFile = ZipOpenPath(zipPath_);
bool showDeleteCheckbox = false;
returnToHomebrew_ = false;
@@ -72,112 +126,107 @@ void InstallZipScreen::CreateViews() {
std::vector<Path> destOptions;
if (zipFile) {
DetectZipFileContents(zipFile, &zipFileInfo_); // Even if this fails, it sets zipInfo->contents.
if (zipFileInfo_.contents == ZipFileContents::ISO_FILE || zipFileInfo_.contents == ZipFileContents::PSP_GAME_DIR) {
std::string_view question = iz->T("Install game from ZIP file?");
switch (zipFileInfo_.contents) {
case ZipFileContents::ISO_FILE:
case ZipFileContents::PSP_GAME_DIR:
{
std::string_view question = iz->T("Install game from ZIP file?");
leftColumn->Add(new TextView(question));
leftColumn->Add(new TextView(shortFilename));
if (!zipFileInfo_.contentName.empty()) {
leftColumn->Add(new TextView(zipFileInfo_.contentName));
}
doneView_ = leftColumn->Add(new TextView(""));
if (zipFileInfo_.contents == ZipFileContents::ISO_FILE) {
const bool isInDownloads = File::IsProbablyInDownloadsFolder(zipPath_);
Path parent;
if (!isInDownloads && zipPath_.CanNavigateUp()) {
parent = zipPath_.NavigateUp();
destFolders_.push_back(parent);
}
if (g_Config.currentDirectory.IsLocalType() && File::Exists(g_Config.currentDirectory) && g_Config.currentDirectory != parent) {
destFolders_.push_back(g_Config.currentDirectory);
}
destFolders_.push_back(g_Config.memStickDirectory);
} else {
destFolders_.push_back(GetSysDirectory(DIRECTORY_GAME));
}
installChoice_ = rightColumnItems->Add(new Choice(iz->T("Install")));
installChoice_->OnClick.Handle(this, &InstallZipScreen::OnInstall);
// NOTE: We detect PBP isos (like demos) as game dirs currently. Can't play them directly.
if (zipFileInfo_.contents == ZipFileContents::ISO_FILE) {
playChoice_ = rightColumnItems->Add(new Choice(ga->T("Play")));
playChoice_->OnClick.Handle(this, &InstallZipScreen::OnPlay);
}
returnToHomebrew_ = true;
showDeleteCheckbox = true;
} else if (zipFileInfo_.contents == ZipFileContents::TEXTURE_PACK) {
std::string_view question = iz->T("Install textures from ZIP file?");
leftColumn->Add(new TextView(question));
leftColumn->Add(new TextView(shortFilename));
doneView_ = leftColumn->Add(new TextView(""));
installChoice_ = rightColumnItems->Add(new Choice(iz->T("Install")));
installChoice_->OnClick.Handle(this, &InstallZipScreen::OnInstall);
showDeleteCheckbox = true;
} else if (zipFileInfo_.contents == ZipFileContents::SAVE_DATA) {
std::string_view question = iz->T("Import savedata from ZIP file");
leftColumn->Add(new TextView(question))->SetBig(true);
leftColumn->Add(new TextView(zipFileInfo_.gameTitle + ": " + zipFileInfo_.savedataDir));
Path savedataDir = GetSysDirectory(DIRECTORY_SAVEDATA);
bool overwrite = !CanExtractWithoutOverwrite(zipFile, savedataDir, 50);
destFolders_.push_back(savedataDir);
if (overwrite) {
leftColumn->Add(new NoticeView(NoticeLevel::WARN, di->T("Confirm Overwrite"), ""));
}
int columnWidth = 300;
LinearLayout *compareColumns = leftColumn->Add(new LinearLayout(ORIENT_HORIZONTAL, new LinearLayoutParams(FILL_PARENT, WRAP_CONTENT)));
LinearLayout *leftCompare = new LinearLayout(ORIENT_VERTICAL);
leftCompare->Add(new TextView(iz->T("Data to import")));
compareColumns->Add(leftCompare);
leftCompare->Add(new SavedataView(*screenManager()->getUIContext(), Path(), IdentifiedFileType::PSP_SAVEDATA_DIRECTORY,
zipFileInfo_.gameTitle, zipFileInfo_.savedataTitle, zipFileInfo_.savedataDetails, NiceSizeFormat(zipFileInfo_.totalFileSize), zipFileInfo_.mTime, false, new LinearLayoutParams(columnWidth, WRAP_CONTENT)));
// Check for potential overwrite at destination, and ask the user if it's OK to overwrite.
if (overwrite) {
savedataToOverwrite_ = savedataDir / zipFileInfo_.savedataDir;
std::shared_ptr<GameInfo> ginfo = g_gameInfoCache->GetInfo(screenManager()->getDrawContext(), savedataToOverwrite_, GameInfoFlags::FILE_TYPE | GameInfoFlags::PARAM_SFO | GameInfoFlags::ICON | GameInfoFlags::SIZE);
LinearLayout *rightCompare = new LinearLayout(ORIENT_VERTICAL);
rightCompare->Add(new TextView(iz->T("Existing data")));
compareColumns->Add(rightCompare);
existingSaveView_ = rightCompare->Add(new SavedataView(*screenManager()->getUIContext(), ginfo.get(), IdentifiedFileType::PSP_SAVEDATA_DIRECTORY, false, new LinearLayoutParams(columnWidth, WRAP_CONTENT)));
if (System_GetPropertyBool(SYSPROP_CAN_SHOW_FILE)) {
rightCompare->Add(new Button(di->T("Show in folder")))->OnClick.Add([=](UI::EventParams &) {
System_ShowFileInFolder(savedataToOverwrite_);
});
}
}
installChoice_ = rightColumnItems->Add(new Choice(iz->T("Install")));
installChoice_->OnClick.Handle(this, &InstallZipScreen::OnInstall);
doneView_ = leftColumn->Add(new TextView(""));
showDeleteCheckbox = true;
} else if (zipFileInfo_.contents == ZipFileContents::FRAME_DUMP) {
leftColumn->Add(new TextView(question));
leftColumn->Add(new TextView(shortFilename));
if (!zipFileInfo_.contentName.empty()) {
leftColumn->Add(new TextView(zipFileInfo_.contentName));
// It's a frame dump, add a play button!
playChoice_ = rightColumnItems->Add(new Choice(ga->T("Play")));
playChoice_->OnClick.Handle(this, &InstallZipScreen::OnPlay);
} else {
leftColumn->Add(new TextView(iz->T("Zip file does not contain PSP software"), ALIGN_LEFT, false, new AnchorLayoutParams(10, 10, NONE, NONE)));
}
doneView_ = leftColumn->Add(new TextView(""));
if (zipFileInfo_.contents == ZipFileContents::ISO_FILE) {
const bool isInDownloads = File::IsProbablyInDownloadsFolder(zipPath_);
Path parent;
if (!isInDownloads && zipPath_.CanNavigateUp()) {
parent = zipPath_.NavigateUp();
destFolders_.push_back(parent);
}
if (g_Config.currentDirectory.IsLocalType() && File::Exists(g_Config.currentDirectory) && g_Config.currentDirectory != parent) {
destFolders_.push_back(g_Config.currentDirectory);
}
destFolders_.push_back(g_Config.memStickDirectory);
} else {
destFolders_.push_back(GetSysDirectory(DIRECTORY_GAME));
}
returnToHomebrew_ = true;
showDeleteCheckbox = true;
break;
}
case ZipFileContents::TEXTURE_PACK:
{
std::string_view question = iz->T("Install textures from ZIP file?");
leftColumn->Add(new TextView(question));
leftColumn->Add(new TextView(shortFilename));
doneView_ = leftColumn->Add(new TextView(""));
showDeleteCheckbox = true;
break;
}
case ZipFileContents::SAVE_DATA:
{
std::string_view question = iz->T("Import savedata from ZIP file");
leftColumn->Add(new TextView(question))->SetBig(true);
leftColumn->Add(new TextView(zipFileInfo_.gameTitle + ": " + zipFileInfo_.savedataDir));
Path savedataDir = GetSysDirectory(DIRECTORY_SAVEDATA);
struct zip *zipFile = ZipOpenPath(zipPath_);
bool overwrite = !CanExtractWithoutOverwrite(zipFile, savedataDir, 50);
ZipClose(zipFile);
} else {
destFolders_.push_back(savedataDir);
if (overwrite) {
leftColumn->Add(new NoticeView(NoticeLevel::WARN, di->T("Confirm Overwrite"), ""));
}
int columnWidth = 300;
LinearLayout *compareColumns = leftColumn->Add(new LinearLayout(ORIENT_HORIZONTAL, new LinearLayoutParams(FILL_PARENT, WRAP_CONTENT)));
LinearLayout *leftCompare = new LinearLayout(ORIENT_VERTICAL);
leftCompare->Add(new TextView(iz->T("Data to import")));
compareColumns->Add(leftCompare);
leftCompare->Add(new SavedataView(*screenManager()->getUIContext(), Path(), IdentifiedFileType::PSP_SAVEDATA_DIRECTORY,
zipFileInfo_.gameTitle, zipFileInfo_.savedataTitle, zipFileInfo_.savedataDetails, NiceSizeFormat(zipFileInfo_.totalFileSize), zipFileInfo_.mTime, false, new LinearLayoutParams(columnWidth, WRAP_CONTENT)));
// Check for potential overwrite at destination, and ask the user if it's OK to overwrite.
if (overwrite) {
savedataToOverwrite_ = savedataDir / zipFileInfo_.savedataDir;
std::shared_ptr<GameInfo> ginfo = g_gameInfoCache->GetInfo(screenManager()->getDrawContext(), savedataToOverwrite_, GameInfoFlags::FILE_TYPE | GameInfoFlags::PARAM_SFO | GameInfoFlags::ICON | GameInfoFlags::SIZE);
LinearLayout *rightCompare = new LinearLayout(ORIENT_VERTICAL);
rightCompare->Add(new TextView(iz->T("Existing data")));
compareColumns->Add(rightCompare);
existingSaveView_ = rightCompare->Add(new SavedataView(*screenManager()->getUIContext(), ginfo.get(), IdentifiedFileType::PSP_SAVEDATA_DIRECTORY, false, new LinearLayoutParams(columnWidth, WRAP_CONTENT)));
if (System_GetPropertyBool(SYSPROP_CAN_SHOW_FILE)) {
rightCompare->Add(new Button(di->T("Show in folder")))->OnClick.Add([=](UI::EventParams &) {
System_ShowFileInFolder(savedataToOverwrite_);
});
}
}
doneView_ = leftColumn->Add(new TextView(""));
showDeleteCheckbox = true;
break;
}
case ZipFileContents::FRAME_DUMP:
leftColumn->Add(new TextView(zipFileInfo_.contentName));
// It's a frame dump, add a play button!
break;
case ZipFileContents::UNKNOWN:
leftColumn->Add(new TextView(iz->T("Zip file does not contain PSP software"), ALIGN_LEFT, false, new AnchorLayoutParams(10, 10, NONE, NONE)));
break;
default:
leftColumn->Add(new TextView(er->T("The file is not a valid zip file"), ALIGN_LEFT, false, new AnchorLayoutParams(10, 10, NONE, NONE)));
break;
}
if (destFolders_.size() > 1) {
@@ -188,14 +237,11 @@ void InstallZipScreen::CreateViews() {
} else if (destFolders_.size() == 1 && zipFileInfo_.contents != ZipFileContents::SAVE_DATA) {
leftColumn->Add(new TextView(StringFromFormat("%s %s", iz->T_cstr("Install into folder:"), destFolders_[0].ToVisualString().c_str())));
}
}
// OK so that EmuScreen will handle it right.
backChoice_ = rightColumnItems->Add(new Choice(di->T("Back")));
backChoice_->OnClick.Handle<UIScreen>(this, &UIScreen::OnOK);
if (showDeleteCheckbox) {
rightColumnItems->Add(new CheckBox(&deleteZipFile_, iz->T("Delete ZIP file")));
}
void InstallZipScreen::BeforeCreateViews() {
File::FileInfo fileInfo;
File::GetFileInfo(zipPath_, &fileInfo);
}
bool InstallZipScreen::key(const KeyInput &key) {