From 00a13bfb142c8bfcbcaf91d6c251bd79382355cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Sat, 30 Aug 2025 11:18:23 +0200 Subject: [PATCH] Fix static analysis warnings (pointless move, empty instead of size) --- Common/GPU/OpenGL/GLRenderManager.cpp | 2 +- android/jni/app-android.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Common/GPU/OpenGL/GLRenderManager.cpp b/Common/GPU/OpenGL/GLRenderManager.cpp index 0967e5138f..80fdb037c5 100644 --- a/Common/GPU/OpenGL/GLRenderManager.cpp +++ b/Common/GPU/OpenGL/GLRenderManager.cpp @@ -140,7 +140,7 @@ bool GLRenderManager::ThreadFrame() { while (renderThreadQueue_.empty()) { pushCondVar_.wait(lock); } - task = std::move(renderThreadQueue_.front()); + task = renderThreadQueue_.front(); renderThreadQueue_.pop(); } diff --git a/android/jni/app-android.cpp b/android/jni/app-android.cpp index 4c33b76137..4ca9c311ce 100644 --- a/android/jni/app-android.cpp +++ b/android/jni/app-android.cpp @@ -939,7 +939,7 @@ extern "C" void Java_org_ppsspp_ppsspp_NativeApp_shutdown(JNIEnv *, jclass) { { std::lock_guard guard(frameCommandLock); - while (frameCommands.size()) + while (!frameCommands.empty()) frameCommands.pop(); } INFO_LOG(Log::System, "NativeApp.shutdown() -- end");