From 7c6a838d7f618cb7750ebf32af93c7d933c2c4ef Mon Sep 17 00:00:00 2001 From: lightningterror <18107717+lightningterror@users.noreply.github.com> Date: Fri, 26 Aug 2022 14:04:38 +0200 Subject: [PATCH] GUI-Wx: Fix variable initializations. Codacy Warning: Variable 'variable' is assigned in constructor body. Consider performing initialization in initialization list. --- pcsx2/gui/AppConfig.cpp | 5 ++--- pcsx2/gui/AppRes.cpp | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pcsx2/gui/AppConfig.cpp b/pcsx2/gui/AppConfig.cpp index 562002e527..98ce9cbb97 100644 --- a/pcsx2/gui/AppConfig.cpp +++ b/pcsx2/gui/AppConfig.cpp @@ -558,8 +558,9 @@ AppConfig::AppConfig() , AppSettingsTabName(L"none") , GameDatabaseTabName(L"none") , LanguageId(wxLANGUAGE_DEFAULT) + , LanguageCode(L"default") + , CdvdSource(CDVD_SourceType::Iso) { - LanguageCode = L"default"; RecentIsoCount = 20; Listbook_ImageSize = 32; Toolbar_ImageSize = 24; @@ -573,8 +574,6 @@ AppConfig::AppConfig() EnablePresets = true; PresetIndex = 1; - - CdvdSource = CDVD_SourceType::Iso; } // ------------------------------------------------------------------------ diff --git a/pcsx2/gui/AppRes.cpp b/pcsx2/gui/AppRes.cpp index 657b17b34b..abe10df6cf 100644 --- a/pcsx2/gui/AppRes.cpp +++ b/pcsx2/gui/AppRes.cpp @@ -39,8 +39,8 @@ #include "gui/Resources/AppIcon64.h" RecentIsoList::RecentIsoList(int firstIdForMenuItems_or_wxID_ANY) + : Menu(std::unique_ptr(new wxMenu())) { - Menu = std::unique_ptr(new wxMenu()); Menu->Append(MenuId_IsoBrowse, _("Browse..."), _("Browse for an ISO that is not in your recent history.")); Menu->AppendSeparator(); Menu->AppendCheckItem(MenuId_Ask_On_Booting, _("Always ask when booting"), _("Manually select an ISO upon boot ignoring the selection from recent ISO list."));