From 6ffaca45da2ea184014f2b46415c4e5c57e46a72 Mon Sep 17 00:00:00 2001 From: KamFretoZ <14798312+kamfretoz@users.noreply.github.com> Date: Sat, 3 May 2025 13:08:56 +0700 Subject: [PATCH] Qt: Fix crashing per-game achievement sound effect settings --- .../Settings/AchievementSettingsWidget.cpp | 35 +++++++++++-------- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/pcsx2-qt/Settings/AchievementSettingsWidget.cpp b/pcsx2-qt/Settings/AchievementSettingsWidget.cpp index d6595d7048..15b4ddec99 100644 --- a/pcsx2-qt/Settings/AchievementSettingsWidget.cpp +++ b/pcsx2-qt/Settings/AchievementSettingsWidget.cpp @@ -117,21 +117,26 @@ void AchievementSettingsWidget::updateEnableState() m_ui.achievementNotificationsDurationLabel->setEnabled(notifications); m_ui.leaderboardNotificationsDuration->setEnabled(lb_notifications); m_ui.leaderboardNotificationsDurationLabel->setEnabled(lb_notifications); - m_ui.notificationSoundPath->setEnabled(info); - m_ui.notificationSoundBrowse->setEnabled(info); - m_ui.notificationSoundOpen->setEnabled(info); - m_ui.notificationSoundReset->setEnabled(info); - m_ui.notificationSound->setEnabled(enabled); - m_ui.unlockSoundPath->setEnabled(unlock); - m_ui.unlockSoundBrowse->setEnabled(unlock); - m_ui.unlockSoundOpen->setEnabled(unlock); - m_ui.unlockSoundReset->setEnabled(unlock); - m_ui.unlockSound->setEnabled(enabled); - m_ui.lbSoundPath->setEnabled(lbsound); - m_ui.lbSoundOpen->setEnabled(lbsound); - m_ui.lbSoundBrowse->setEnabled(lbsound); - m_ui.lbSoundReset->setEnabled(lbsound); - m_ui.lbSound->setEnabled(enabled); + + if (!m_dialog->isPerGameSettings()) + { + m_ui.notificationSoundPath->setEnabled(info); + m_ui.notificationSoundBrowse->setEnabled(info); + m_ui.notificationSoundOpen->setEnabled(info); + m_ui.notificationSoundReset->setEnabled(info); + m_ui.notificationSound->setEnabled(enabled); + m_ui.unlockSoundPath->setEnabled(unlock); + m_ui.unlockSoundBrowse->setEnabled(unlock); + m_ui.unlockSoundOpen->setEnabled(unlock); + m_ui.unlockSoundReset->setEnabled(unlock); + m_ui.unlockSound->setEnabled(enabled); + m_ui.lbSoundPath->setEnabled(lbsound); + m_ui.lbSoundOpen->setEnabled(lbsound); + m_ui.lbSoundBrowse->setEnabled(lbsound); + m_ui.lbSoundReset->setEnabled(lbsound); + m_ui.lbSound->setEnabled(enabled); + } + m_ui.soundEffects->setEnabled(enabled); m_ui.overlays->setEnabled(enabled); m_ui.encoreMode->setEnabled(enabled);