From cc7e03c2dde9507d489c20735dcc2e9cb3fd7169 Mon Sep 17 00:00:00 2001 From: Stenzek Date: Sat, 7 Mar 2026 19:52:43 +1000 Subject: [PATCH] Settings: Use case-sensitive comparison when loading Haven't manually edited the config in years... --- src/core/settings.cpp | 58 +++++++++++++++++++++---------------------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/src/core/settings.cpp b/src/core/settings.cpp index 233fe1c69..7d804e442 100644 --- a/src/core/settings.cpp +++ b/src/core/settings.cpp @@ -1322,7 +1322,7 @@ std::optional Settings::ParseLogLevelName(std::string_view str) int index = 0; for (const char* name : s_log_level_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1359,7 +1359,7 @@ std::optional Settings::ParseConsoleRegionName(std::string_view s int index = 0; for (const char* name : s_console_region_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1395,7 +1395,7 @@ std::optional Settings::ParseDiscRegionName(std::string_view str) int index = 0; for (const char* name : s_disc_region_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1430,7 +1430,7 @@ std::optional Settings::ParseCPUExecutionMode(std::string_view u8 index = 0; for (const char* name : s_cpu_execution_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1466,7 +1466,7 @@ std::optional Settings::ParseCPUFastmemMode(std::string_view str u8 index = 0; for (const char* name : s_cpu_fastmem_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1525,7 +1525,7 @@ std::optional Settings::ParseRendererName(std::string_view str) int index = 0; for (const char* name : s_gpu_renderer_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1632,7 +1632,7 @@ std::optional Settings::ParseTextureFilterName(std::string_vie int index = 0; for (const char* name : s_texture_filter_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1671,7 +1671,7 @@ std::optional Settings::ParseGPUDitheringModeName(std::string_ int index = 0; for (const char* name : s_gpu_dithering_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1709,7 +1709,7 @@ std::optional Settings::ParseLineDetectModeName(std::string_v int index = 0; for (const char* name : s_line_detect_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1740,7 +1740,7 @@ std::optional Settings::ParseDownsampleModeName(std::string_v int index = 0; for (const char* name : s_downsample_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1771,7 +1771,7 @@ std::optional Settings::ParseGPUWireframeMode(std::string_view int index = 0; for (const char* name : s_wireframe_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1811,7 +1811,7 @@ std::optional Settings::ParseGPUDumpCompressionMode(std: int index = 0; for (const char* name : s_gpu_dump_compression_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1847,7 +1847,7 @@ std::optional Settings::ParseDisplayDeinterlacingMode( int index = 0; for (const char* name : s_display_deinterlacing_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1883,7 +1883,7 @@ std::optional Settings::ParseDisplayCropMode(std::string_view s int index = 0; for (const char* name : s_display_crop_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -1923,7 +1923,7 @@ std::optional Settings::ParseDisplayFineCropMode(std::strin int index = 0; for (const char* name : s_display_fine_crop_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2042,7 +2042,7 @@ std::optional Settings::ParseDisplayAlignment(std::string_view int index = 0; for (const char* name : s_display_alignment_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2075,7 +2075,7 @@ std::optional Settings::ParseDisplayRotation(std::string_view s int index = 0; for (const char* name : s_display_rotation_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2112,7 +2112,7 @@ std::optional Settings::ParseForceVideoTimingName(std::str int index = 0; for (const char* name : s_display_force_video_timing_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2150,7 +2150,7 @@ std::optional Settings::ParseDisplayScaling(std::string_view int index = 0; for (const char* name : s_display_scaling_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2186,7 +2186,7 @@ std::optional Settings::ParseDisplayExclusive int index = 0; for (const char* name : s_display_exclusive_fullscreen_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2223,7 +2223,7 @@ std::optional Settings::ParseDisplayScreenshotMode(std::s int index = 0; for (const char* name : s_display_screenshot_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2264,7 +2264,7 @@ std::optional Settings::ParseDisplayScreenshotFormat(st int index = 0; for (const char* name : s_display_screenshot_format_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2333,7 +2333,7 @@ std::optional Settings::ParseNotificationLocation(std::str int index = 0; for (const char* name : s_notification_location_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2375,7 +2375,7 @@ std::optional Settings::ParseAchievementChall int index = 0; for (const char* name : s_achievement_challenge_indicator_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2413,7 +2413,7 @@ std::optional Settings::ParseMemoryCardTypeName(std::string_view int index = 0; for (const char* name : s_memory_card_type_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2475,7 +2475,7 @@ std::optional Settings::ParseMultitapModeName(std::string_view str u32 index = 0; for (const char* name : s_multitap_enable_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2507,7 +2507,7 @@ std::optional Settings::ParseCDROMMechVersionName(std::str u32 index = 0; for (const char* name : s_mechacon_version_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2551,7 +2551,7 @@ std::optional Settings::ParseSaveStateCompressionModeN u32 index = 0; for (const char* name : s_save_state_compression_mode_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++; @@ -2587,7 +2587,7 @@ std::optional Settings::ParsePIODeviceTypeName(std::string_view s u32 index = 0; for (const char* name : s_pio_device_type_names) { - if (StringUtil::EqualNoCase(name, str)) + if (str == name) return static_cast(index); index++;