34311f5fa2
Merge pull request #14592 from jordan-woyak/memcard-manager-scrolling
...
DolphinQt/GCMemcardManager: Set ScrollMode::ScrollPerPixel to make scrolling behavior less annoying.
2026-05-11 23:04:22 +02:00
95dec13203
Improve usage of std::move and const references parameters
...
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.
Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.
Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
2026-04-17 12:39:46 +02:00
fb607239e5
DolphinQt/GCMemcardManager: Don't unnecessarily repopulate the slot table when switching between A <-> B.
2026-04-14 11:05:06 -05:00
52ef8d3f8d
DolphinQt/GCMemcardManager: Set ScrollMode::ScrollPerPixel to make scrolling behavior less annoying.
2026-04-14 11:04:03 -05:00
a14c88ba67
Remove unused imports
...
Yellow squiggly lines begone!
Done automatically on .cpp files through `run-clang-tidy`, with manual corrections to the mistakes.
If an import is directly used, but is technically unnecessary since it's recursively imported by something else, it is *not* removed.
The tool doesn't touch .h files, so I did some of them by hand while fixing errors due to old recursive imports.
Not everything is removed, but the cleanup should be substantial enough.
Because this done on Linux, code that isn't used on it is mostly untouched.
(Hopefully no open PR is depending on these imports...)
2026-01-25 16:12:15 +01:00
5906512847
DolphinQt: Replace widespread SetQWidgetWindowDecorations calls with an event filter.
2025-06-07 16:15:34 -05:00
2a7e8a4003
DolphinQt: Remove redundant window hints
...
Remove window hints clearing the flag Qt::WindowContextHelpButtonHint,
which is already off by default in Qt 6.
In Qt 5 this flag was set by default for QDialogs, and on Windows put a
? button in the corner of the title bar allowing users to activate Qt's
QWhatsThis help system for a given widget. Since we don't set that text
the ? button was useless and so we hid it manually.
2025-06-06 19:35:13 -07:00
9602f36248
Remove redundant semicolons
2024-08-20 14:59:54 +02:00
9d2f5245f4
i18n: Add comments and improve source strings
...
Most of these changes are to improve consistency in capitalization.
2024-07-28 14:38:20 +02:00
e2fb8fab2f
DolphinQt: Set window decorations for all top-level QWidgets.
2023-08-12 16:54:54 +02:00
1044bc40ca
GCMemcardUtils: Make use of std::span where applicable
...
Generifies bits of the interface so that some functions aren't
explicitly tied down to only using std::vector.
2023-06-08 12:59:43 -04:00
bf079d6d3a
[[unlikely]] ASSERT
...
and other ASSERT usage changes
2023-03-02 19:54:15 -06:00
4fd18cf207
DolphinQt: Unify handling of raw memory card path.
2022-06-05 21:48:13 +02:00
a4d031cfda
Add NonDefaultQPushButton to set autoDefault of buttons to false
2022-03-08 08:51:29 +01:00
9109258b85
Use Slot in GCMemcardManager
2022-01-16 14:21:32 -08:00
d354163fbe
Replace TEXIDevices with an enum class
2022-01-14 20:24:53 -08:00
839b04014e
Add wrapper function to disable hotkeys for QFileDialog
...
Previously, if you have "Hotkeys Require Window Focus" disabled, you could repeatedly use the "Open" hotkey, for example, to stack File Open windows over top of each other over and over.
This commit allows the hotkey manager to disable/enable on QFileDialog creation and destruction.
2021-10-09 22:43:56 -04:00
e149ad4f0a
treewide: convert GPLv2+ license info to SPDX tags
...
SPDX standardizes how source code conveys its copyright and licensing
information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX
tags are adopted in many large projects, including things like the Linux
kernel.
2021-07-05 04:35:56 +02:00
004dfd1586
Replace uses of cassert with Common/Assert.h
2021-04-02 10:18:18 -07:00
e47eb16641
GCMemcardManager: Detect attempt to import multiple save files with the same internal name.
2021-01-28 22:01:33 +01:00
74b56a8c7f
GCMemcardManager: Add filename column.
2021-01-28 22:01:33 +01:00
9acbe1aced
GCMemcardManager: Make columns sortable.
2021-01-28 22:01:33 +01:00
42f4ee629b
GCMemcardManager: Make columns resizable by the user.
2021-01-28 22:01:33 +01:00
7cf991bd8a
GCMemcardManager: Small cleanups.
2021-01-28 22:01:33 +01:00
e00e6e1a8c
GCMemcardManager: Replace remaining panic alert with ModalMessageBox.
2021-01-28 22:01:33 +01:00
daa76183ed
GCMemcard: Let ImportFile() take a Savefile instead of a direntry and a vector of blocks.
2021-01-28 22:01:33 +01:00
e8b99d3afd
GCMemcardManager: Rewrite file deleting logic to provide a better user experience.
2021-01-28 22:01:33 +01:00
6e96f95432
GCMemcardManager: Rewrite file copying logic to provide a better user experience.
2021-01-28 22:01:33 +01:00
08dccb8727
GCMemcardManager: Rewrite file importing logic to provide a better user experience.
2021-01-28 22:01:33 +01:00
87ae7ccd75
GCMemcardManager: Rewrite file exporting logic to provide a better user experience.
2021-01-28 22:01:32 +01:00
7bb7aa16c2
GCMemcardManager: Relayout file table for a more compact design.
2021-01-28 22:01:32 +01:00
ffbf3d71f0
Frontends: Migrate logs over to fmt
2020-11-25 21:19:08 -05:00
914ebdf0dd
GCMemcard: Move from global namespace into a Memcard namespace.
2020-06-16 20:18:39 +02:00
e921cbe57c
GCMemcardManager: Add GUI to create new memory card.
2020-04-28 23:59:15 +02:00
7c7a41ecd8
Cleanup warnings of -Wunused-variable
...
remove unused variables.
2020-03-23 14:24:27 +08:00
b9f34bc822
DolphinQt: setTabKeyNavigation(false) on QTableWidget and QTableView.
2020-02-06 20:48:45 -06:00
7eaa769527
DolphinQt/GCMemcardManager: Make use of QLatin1Char within GetErrorMessagesForErrorCode()
...
Same behavior, but eliminates the use of a program lifetime Qt string
literal.
2020-01-27 15:59:33 -05:00
585ae8aedf
DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode()
...
This is a string that can potentially be seen by a user, so it should be
marked as translatable, like the other strings are.
2020-01-27 15:57:36 -05:00
d6eb75b272
GCMemcardManager : Performance boost
2019-11-17 20:45:24 +01:00
bc1aa3640b
Merge pull request #8302 from AdmiralCurtiss/gcmemcard-comments
...
GCMemcard: Read comments, banners, and icons via logical data offsets instead of physical ones.
2019-11-17 10:34:06 +01:00
3b67d0d90a
GCMemcard: Read icons according to logical data offsets instead of physical data offsets. Also gets rid of some undefined behavior.
2019-11-17 01:42:26 +01:00
110d6c1da3
GCMemcard: Read banners according to logical data offsets instead of physical data offsets. Also gets rid of some undefined behavior.
2019-11-17 01:42:26 +01:00
2f119bd206
GCMemcard: Move Icon and Banner constants to the GCMemcard header.
2019-11-17 01:42:26 +01:00
58f21830bd
GCMemcard: Read file comments according to logical data offsets instead of physical data offsets.
2019-11-17 01:42:26 +01:00
c167543eb3
Merge pull request #8185 from Techjar/memcard-manager-auto
...
Qt/GCMemcardManager: Load configured memory cards by default
2019-11-09 23:06:57 +01:00
1c1c19e996
Qt/GCMemcardManager: Fix incorrect placeholder frame timing.
2019-10-21 22:47:17 +02:00
4a613dad20
Merge pull request #8304 from AdmiralCurtiss/memcard-manager-icon-fix
...
Qt/GCMemcardManager: Fix icon animations displaying incorrectly.
2019-10-17 18:03:21 -04:00
dbc0bf0ccb
Fix import gc save file window title
2019-09-24 19:16:27 +10:00
ff90a5855d
Qt/GCMemcardManager: Fix animation frame order and speed.
2019-09-23 01:55:46 +02:00
8f573cf5f2
Qt/GCMemcardManager: Fix animation frame decoding.
2019-09-22 21:55:06 +02:00
Admiral H. Curtiss