Commit Graph
39010 Commits
Author SHA1 Message Date
Admiral H. Curtiss 061f3e95bb Merge pull request #14863 from brad0/openbsd_getexecpath
Implement File::GetExePath() for OpenBSD with getexecpath()
2026-10-02 19:52:29 +02:00
Admiral H. Curtiss 8e7521c46e Merge pull request #14900 from VampireFlower/assembler-fix
Assembler: Fix crash from assembling malformed source
2026-10-02 19:50:37 +02:00
JMC47 24c80c5a32 Merge pull request #14590 from jordan-woyak/mmu-256-mem2
PowerPC/MMU: Change mask in DMA_LCToMemory and DMA_MemoryToLC functions to allow for a 256MiB MEM2.
2026-10-02 06:29:32 -04:00
Jordan Woyak 8fe19d1118 Merge pull request #14860 from JoshuaVandaele/inputsyntax-nodecimal
Input Syntax: Add floor, ceil, round, and trunc functions
2026-10-02 03:47:24 -05:00
JMC47 5390a61e52 Merge pull request #14880 from ICEREG1992/GBARouting
Integrated GBA Audio Routing
2026-10-02 01:58:20 -04:00
VampireFlower 902587cae2 Assembler: Fix crash from assembling malformed source 2026-09-30 04:04:23 -06:00
JosJuice 5102a0339c Merge pull request #14893 from tom-pratt/android-settings-crash
Fix android settings crash on API level 28 and lower
2026-09-28 08:24:28 +02:00
JosJuice 5f395ab792 Android: Set abiFilters for ndk
Normally, Dolphin APKs have a lib folder that contains two subfolders:
arm64-v8a and x86_64. Both contain a libmain.so file, and arm64-v8a also
contains additional .so files for libadrenotools.

When we added netplay support for Android, we brought in Jetpack Compose
as a dependency, which in turn made libandroidx.graphics.path.so be
included in Dolphin APKs. Unfortunately, this .so file was included not
only for arm64-v8a and x86_64, but also for armeabi-v7a and x86. This
made Dolphin installable on devices that use one of these older ABIs,
but because libmain.so is missing, trying to start Dolphin on such a
device results in an instant crash. We have gotten a number of Google
Play reviews from armeabi-v7a users complaining about this crash.

This fixes the problem by setting abiFilters under ndk instead of under
cmake, as documented at https://developer.android.com/ndk/guides/abis.
2026-09-27 21:31:29 +02:00
Tom Pratt b5748b81d6 Fix android settings crash on API level 28 and lower
These API levels don't allow color selectors to be used as backgrounds.

Switch to MaterialDivider and set the color via dividerColor instead of background.
2026-09-27 21:04:53 +02:00
Admiral H. Curtiss 465c652da1 Merge pull request #14887 from SuperSamus/statistics-unsigned-members
VideoCommon/Statistics: Use unsigned int where appropriate
2026-09-24 23:42:38 +02:00
Martino Fontana 910eeffc08 VideoCommon/Statistics: Use unsigned int where appropriate
Some poorly coded games are able to overflow some statistics (e.g. Jimmy Neutron: Boy Genius's title screen).
While funny, signed integer overflow is undefined behavior, and while in practice here it's extremely unlikely to cause issues, it's still better to avoid it.
2026-09-24 12:05:18 +02:00
Jordan Woyak 9599525ea1 PowerPC/MMU: Changed mask in DMA_LCToMemory and DMA_MemoryToLC functions to allow for a 256MiB MEM2.
Also adjusted maximum value for MEM2 to 256 MiB for Qt and Android UIs.
2026-09-21 13:37:59 -05:00
JosJuice 4619af1be0 Merge pull request #14883 from AdmiralCurtiss/zelda-hle-voice-flags
DSPHLE/Zelda: Add bounds check for m_sync_voice_skip_flags in RenderAudio()
2026-09-21 18:23:48 +02:00
JosJuice 22342c2303 Merge pull request #14882 from JosJuice/gci-folder-block-index
GCMemcardDirectory: Add bounds check for m_save_data
2026-09-21 18:23:39 +02:00
Admiral H. Curtiss b84323e108 DSPHLE/Zelda: Add bounds check for m_sync_voice_skip_flags in RenderAudio() 2026-09-20 22:51:17 +02:00
JosJuice 8f674f574a Merge pull request #14833 from JosJuice/state-nand-tas
IOS/FS: Fix loading savestate while TASing
2026-09-20 22:30:42 +02:00
JosJuice f8a5c5c10b GCMemcardDirectory: Check if UsesBlock result is non-negative
The only negative result UsesBlock can return is -1, so this change
doesn't affect anything in practice, but makes the intent a little bit
clearer.
2026-09-20 22:18:45 +02:00
William Sullivan 0e6e00b1ef Integrated GBA Audio Routing 2026-09-20 15:10:16 -05:00
JosJuice 56e8b740f1 GCMemcardDirectory: Add bounds check for m_save_data 2026-09-20 20:13:19 +02:00
JosJuice 093d3abe95 IOS/FS: Fix loading savestate while TASing, part 2
When calling CreateDirectory for /wfs, we were passing a UID of 19,
because that is the UID /wfs is supposed to have. However,
CreateDirectory returns AccessDenied if we try to create a directory in
the root using a UID other than 0.

To fix this, let's use UID 0 to create the directory, and then change
the UID and GID afterwards using SetMetadata. This is what the ESCore
constructor does, which is the piece of code that normally creates /wfs.
2026-09-20 11:59:28 +02:00
JosJuice 4fcd61620f IOS/FS: Fix loading savestate while TASing, part 1
When TASing, we savestate not just /tmp but also /. The code that was
added in d35fe1b didn't handle recreating / correctly.

This commit fixes the problem by skipping recreating /, which is fine
since it always exists.
2026-09-20 11:56:57 +02:00
JosJuice dbff13226c Merge pull request #14867 from brad0/openbsd_build_fix
Fix building on OpenBSD
2026-09-20 10:08:10 +02:00
Admiral H. Curtiss ee018d00e6 Merge pull request #14868 from JoshuaVandaele/index-regression
NetPlayIndex: Fix regression introduced in #14738
2026-09-17 01:36:38 +02:00
Admiral H. Curtiss 3d26cfb1f3 Merge pull request #14869 from cristian64/ram_override_ios
Core: Fix RAM override setup in IOS.
2026-09-17 01:32:08 +02:00
Admiral H. Curtiss a96b5da856 Merge pull request #14832 from JoshuaVandaele/windeployqt-fix
DolphinQt: Properly define QtPaths
2026-09-17 01:22:55 +02:00
cristian64 2039b5524e Core: Fix RAM override setup in IOS.
This is a correction for 0cab1731d6 (part of #14665), where it was
overlooked that the condition to enable the RAM override was flawed: if
the user had enabled the emulated memory size override in Dolphin, but
the running game did not define a simulated memory size greater than the
retail memory size, the RAM override in IOS was wrongly misconfigured,
causing issues with Wii games.

Test plan:

- Launch Dolphin.
- In the **Settings > Advanced** section, tick the **Enable Emulated
  Memory Size Override** check box, and set the maximum memory size for
  both **MEM1** and **MEM2** (i.e. 64 MiB and 128 MiB respectively).
- Play any Wii game (e.g. _Mario Kart Wii_ (RMCE01)).

**Without** the patch, the emulator will hit an invalid read from
`0x83FEE78C` at `0x8019FE6C`:

<img alt="Invalid read when starting Wii game after having enabled the emulated memory override in Dolphin" title="Invalid read when starting Wii game after having enabled the emulated memory override in Dolphin" src="https://github.com/user-attachments/assets/1777485e-a421-4303-8d3d-dd49f1aaa9bf" />

**With** the patch, the emulator can execute the game as usual.
2026-09-15 20:53:31 +01:00
Joshua Vandaële 9386b577b3 NetPlayIndex: Fix regression introduced in 14738
For some reason, #14738 removed the headers and allowed return codes which broke using the Netplay index for users.
Also, bools converted to a string using std::to_string would become 0/1, while fmt::format by default turns them into false/true, which also broke the index.
2026-09-15 09:44:41 +02:00
Brad Smith 191292946f Fix building on OpenBSD
- OpenBSD does not have SO_NOSIGPIPE
- Enable some socket related code in AMMediaboard.cpp on OpenBSD
2026-09-15 01:22:34 -04:00
Brad Smith 71165c82a5 Implement File::GetExePath() for OpenBSD with getexecpath() 2026-09-15 00:49:03 -04:00
Joshua Vandaële 0cbf5a80ab Input Syntax: Add floor, ceil, round, and trunc functions 2026-09-11 22:38:03 +02:00
LillyJadeKatrin 3a55a0e1a2 RetroAchievements - Fix Achievement Progress Toggle
The RA_PROGRESS_ENABLED flag was added but not currently being invoked, this
makes sure it is checked before popping up progress messages.
2026-09-07 09:59:22 -04:00
Link Mauve 3e95d0fc16 Revert "VideoCommon: Use correct size for PE token"
This reverts commit e4349ae179.

The 0x prefix is included in the characters count (unlike e.g. in Rust
where there is no 0x prefix), so that commit was wrong.  Sorry about
that!

Fixes regression introduced in #14842.
2026-09-06 09:06:48 +02:00
Dentomologist 982e8d183d Merge pull request #14817 from JosJuice/android-netplay-version
Common: Add Android to GetNetplayDolphinVer
2026-09-05 22:04:48 -07:00
Scott Mansell debe8e9fd9 Merge pull request #14789 from phire/optimise_vs_uid
Optimize vertex_shader_uid_data down to 28 bytes
2026-09-06 14:37:57 +12:00
Scott Mansell bd389f6b00 Merge pull request #14843 from linkmauve/better-dff-error-message
Core: Improve error message on empty dff
2026-09-06 12:06:31 +12:00
Scott Mansell ef0038dded Merge pull request #14842 from linkmauve/pe-token-2-bytes
VideoCommon: Use correct size for PE token
2026-09-06 12:06:17 +12:00
JosJuice 7f6eb621ad Merge pull request #14838 from OatmealDome/mac-memory-increase-fail
MemArenaDarwin: Pass the MAP_MEM_VM_SHARE flag to mach_make_memory_entry_64
2026-09-05 12:18:19 +02:00
Link Mauve f80a78869a HW/EXI: Don’t dereference one item past end of array
Dolphin would previously crash while accessing &buffer[got], as if we
were trying to access that element instead of just obtaining a pointer
to it.  The proper solution is to obtain a pointer to the first element,
and only add the offset we want to get the range.

Here is the printed message:
/usr/include/c++/16/array:210: constexpr std::array<_Tp, _Nm>::value_type& std::array<_Tp, _Nm>::operator[](size_type) [with _Tp = char; long unsigned int _Nm = 128; reference = char&; size_type = long unsigned int]: Assertion '__n < this->size()' failed.

The stack trace originates from:
Source/Core/Core/HW/EXI/EXI_DeviceGecko.cpp:139
2026-09-04 15:37:36 +02:00
JosJuice ca8c6ee45e Merge pull request #14830 from JoshuaVandaele/sdl-miscs
SDLGamepad: Add Misc 2 through 6
2026-09-03 21:28:31 +02:00
JosJuice 5ff90a0471 Merge pull request #14686 from JoshuaVandaele/sdl-touchpads
SDLGamepad: Support multiple touchpads
2026-09-03 21:28:20 +02:00
Link Mauve cdb1744994 Core: Improve error message on empty dff
This also lets us remove the comment, which is now unnecessary.
2026-09-03 11:51:35 +02:00
Link Mauve e4349ae179 VideoCommon: Use correct size for PE token
This token is a u16, not a u24, so let’s not display unnecessary 00
padding.
2026-09-03 11:49:13 +02:00
OatmealDome 27804b4e67 MemArenaDarwin: Pass the MAP_MEM_VM_SHARE flag to mach_make_memory_entry_64
Large anonymous mappings are split into 128 MB chunks. Without MAP_MEM_VM_SHARE,
mach_make_memory_entry_64 will only return an entry spanning the first chunk.
Attempting to map through that entry will fail if it extends beyond the 128 MB
boundary, which can happen when the sizes of MEM1/MEM2 are overridden.
2026-09-01 22:25:12 -04:00
iwubcode 9263f6b7c6 VideoCommon: separate out reinterpret and palette texture creation from rendering 2026-08-31 19:51:30 -05:00
Joshua Vandaële e9c5b57d88 DolphinQt: Properly define QtPaths
This fixes cross-compilation on Windows, where windeplotqt would previously always grab the host's DLLs instead of the target's.
2026-08-30 07:34:06 +02:00
Dentomologist 1fd7f35218 Merge pull request #14818 from JoshuaVandaele/gridview-title
GameList: Enable word wrap in grid view
2026-08-29 21:51:10 -07:00
JosJuice dfe15b9e24 Merge pull request #14824 from JosJuice/save-controller-to-dtm
Core: Fix controllers resetting when starting input recording
2026-08-29 11:20:54 +02:00
JosJuice 30c9669d7b Merge pull request #14750 from tom-pratt/netplay-controller-mapping
Android: Netplay controller mapping
2026-08-29 11:19:47 +02:00
JosJuice 9b50b88d2e Merge pull request #14829 from TorresOwO/fix-skylanders-crash-13956
Android: Fix Crash when loading Skylanders file
2026-08-29 11:15:38 +02:00
Tom Pratt 0bca7edf20 Fix netplay crash on pre API 31 devices
TypedArray doesn't implement AutoCloseable on older devices so .use{} caused a crash.

It turned out the special handling for background colours was unnecessary anyway.
2026-08-28 14:11:50 +02:00