chore: rector (#970)

This commit is contained in:
Kyrch
2025-10-01 17:18:31 -03:00
committed by GitHub
parent ac9b4be61b
commit ad899b7271
754 changed files with 1746 additions and 3674 deletions
+3 -3
View File
@@ -51,8 +51,8 @@ class UserFactory extends Factory
public function withPermissions(string ...$abilities): static
{
return $this->afterCreating(
function (User $user) use ($abilities) {
$permissions = Arr::map($abilities, fn (string $ability) => Permission::findOrCreate($ability));
function (User $user) use ($abilities): void {
$permissions = Arr::map($abilities, fn (string $ability): \Spatie\Permission\Contracts\Permission => Permission::findOrCreate($ability));
App::make(PermissionRegistrar::class)->forgetCachedPermissions();
@@ -67,7 +67,7 @@ class UserFactory extends Factory
public function withAdmin(): static
{
return $this->afterCreating(
function (User $user) {
function (User $user): void {
$admin = Role::findOrCreate('Admin');
$user->assignRole($admin);
@@ -51,7 +51,7 @@ class ExternalProfileFactory extends Factory
public function entries(int $count): static
{
return $this->afterCreating(
function (ExternalProfile $profile) use ($count) {
function (ExternalProfile $profile) use ($count): void {
foreach (range(1, $count) as $index) {
$entry = ExternalEntry::factory()
->for($profile)
@@ -75,7 +75,7 @@ class ExternalProfileFactory extends Factory
public function entriesForIds(array $animeIds): static
{
return $this->afterCreating(
function (ExternalProfile $profile) use ($animeIds) {
function (ExternalProfile $profile) use ($animeIds): void {
foreach ($animeIds as $animeId) {
$entry = ExternalEntry::factory()
->for($profile)
+4 -3
View File
@@ -52,7 +52,7 @@ class PlaylistFactory extends Factory
public function tracks(int $count): static
{
return $this->afterCreating(
function (Playlist $playlist) use ($count) {
function (Playlist $playlist) use ($count): void {
$tracks = [];
foreach (range(1, $count) as $index) {
@@ -101,10 +101,11 @@ class PlaylistFactory extends Factory
public function tracksForIds(array $videoIds): static
{
return $this->afterCreating(
function (Playlist $playlist) use ($videoIds) {
function (Playlist $playlist) use ($videoIds): void {
$tracks = [];
$counter = count($videoIds);
for ($index = 0; $index < count($videoIds); $index++) {
for ($index = 0; $index < $counter; $index++) {
$videoId = $videoIds[$index];
/** @var PlaylistTrack|null $last */
+1 -1
View File
@@ -62,7 +62,7 @@ class AnimeFactory extends Factory
public function jsonApiResource(): static
{
return $this->afterCreating(
function (Anime $anime) {
function (Anime $anime): void {
AnimeSynonym::factory()
->for($anime)
->count(fake()->numberBetween(1, 3))
+1 -1
View File
@@ -50,7 +50,7 @@ class ArtistFactory extends Factory
public function jsonApiResource(): static
{
return $this->afterCreating(
function (Artist $artist) {
function (Artist $artist): void {
Song::factory()
->hasAttached($artist)
->has(AnimeTheme::factory()->for(Anime::factory()))
@@ -103,8 +103,6 @@ class PermissionSeeder extends Seeder
/**
* Register resource abilities.
*
* @param array $abilities
*/
protected function registerResource(string $resource, array $abilities): void
{
+1 -1
View File
@@ -109,7 +109,7 @@ class AdminSeeder extends RoleSeeder
$this->configureAbilities(
$role,
array_column(
Arr::reject(SpecialPermission::cases(), fn ($value) => $value === SpecialPermission::BYPASS_AUTHORIZATION),
Arr::reject(SpecialPermission::cases(), fn ($value): bool => $value === SpecialPermission::BYPASS_AUTHORIZATION),
'value'
)
);
@@ -5,7 +5,6 @@ declare(strict_types=1);
namespace Database\Seeders\Auth\Role;
use App\Enums\Auth\CrudPermission;
use App\Enums\Auth\ExtendedCrudPermission;
use App\Enums\Auth\Role as RoleEnum;
use App\Enums\Auth\SpecialPermission;
use App\Models\Auth\Role;
@@ -49,11 +48,6 @@ class ContributorRoleSeeder extends RoleSeeder
/** @var Role $role */
$role = Role::findOrCreate($roleEnum->value);
$extendedCrudPermissions = array_merge(
CrudPermission::cases(),
ExtendedCrudPermission::cases(),
);
// Discord Resources
$this->configureResource($role, DiscordThread::class, [CrudPermission::VIEW]);
@@ -5,7 +5,6 @@ declare(strict_types=1);
namespace Database\Seeders\Auth\Role;
use App\Enums\Auth\CrudPermission;
use App\Enums\Auth\ExtendedCrudPermission;
use App\Enums\Auth\Role as RoleEnum;
use App\Enums\Auth\SpecialPermission;
use App\Models\Auth\Role;
@@ -48,11 +47,6 @@ class DeveloperRoleSeeder extends RoleSeeder
/** @var Role $role */
$role = Role::findOrCreate($roleEnum->value);
$extendedCrudPermissions = array_merge(
CrudPermission::cases(),
ExtendedCrudPermission::cases(),
);
// Discord Resources
$this->configureResource($role, DiscordThread::class, [CrudPermission::VIEW]);
@@ -5,7 +5,6 @@ declare(strict_types=1);
namespace Database\Seeders\Auth\Role;
use App\Enums\Auth\CrudPermission;
use App\Enums\Auth\ExtendedCrudPermission;
use App\Enums\Auth\Role as RoleEnum;
use App\Enums\Auth\SpecialPermission;
use App\Models\Auth\Role;
@@ -49,11 +48,6 @@ class PanelViewerRoleSeeder extends RoleSeeder
/** @var Role $role */
$role = Role::findOrCreate($roleEnum->value);
$extendedCrudPermissions = array_merge(
CrudPermission::cases(),
ExtendedCrudPermission::cases(),
);
// Discord Resources
$this->configureResource($role, DiscordThread::class, [CrudPermission::VIEW]);
@@ -5,7 +5,6 @@ declare(strict_types=1);
namespace Database\Seeders\Auth\Role;
use App\Enums\Auth\CrudPermission;
use App\Enums\Auth\ExtendedCrudPermission;
use App\Enums\Auth\Role as RoleEnum;
use App\Enums\Auth\SpecialPermission;
use App\Models\Auth\Role;
@@ -48,11 +47,6 @@ class PatronRoleSeeder extends RoleSeeder
/** @var Role $role */
$role = Role::findOrCreate($roleEnum->value);
$extendedCrudPermissions = array_merge(
CrudPermission::cases(),
ExtendedCrudPermission::cases(),
);
// Discord Resources
$this->configureResource($role, DiscordThread::class, [CrudPermission::VIEW]);
+2 -3
View File
@@ -37,7 +37,7 @@ class RoleSeeder extends Seeder
{
$permissions = Arr::map(
$abilities,
fn (CrudPermission|ExtendedCrudPermission $ability) => Permission::findByName($ability->format($resource))
fn (CrudPermission|ExtendedCrudPermission $ability): \Spatie\Permission\Contracts\Permission => Permission::findByName($ability->format($resource))
);
$role->givePermissionTo($permissions);
@@ -46,12 +46,11 @@ class RoleSeeder extends Seeder
/**
* Configure role with abilities.
*
* @param Role $role
* @param string[] $abilities
*/
protected function configureAbilities(Role $role, array $abilities): void
{
$permissions = Arr::map($abilities, fn (string $ability) => Permission::findByName($ability));
$permissions = Arr::map($abilities, fn (string $ability): \Spatie\Permission\Contracts\Permission => Permission::findByName($ability));
$role->givePermissionTo($permissions);
}
@@ -17,7 +17,7 @@ class PlaylistHashidsSeeder extends Seeder
public function run(): void
{
Playlist::query()
->chunkById(100, fn (Collection $playlists) => $playlists->each(function (Playlist $playlist) {
->chunkById(100, fn (Collection $playlists) => $playlists->each(function (Playlist $playlist): void {
$action = new AssignHashidsAction();
$action->assign($playlist, 'playlists');
@@ -17,7 +17,7 @@ class TrackHashidsSeeder extends Seeder
public function run(): void
{
PlaylistTrack::query()
->chunkById(100, fn (Collection $tracks) => $tracks->each(function (PlaylistTrack $track) {
->chunkById(100, fn (Collection $tracks) => $tracks->each(function (PlaylistTrack $track): void {
$action = new AssignHashidsAction();
$action->assign($track, 'playlists');
@@ -21,7 +21,7 @@ class BackfillAudioSeeder extends Seeder
{
Video::query()
->whereDoesntHave(Video::RELATION_AUDIO)
->chunkById(100, fn (Collection $videos) => $videos->each(function (Video $video) {
->chunkById(100, fn (Collection $videos) => $videos->each(function (Video $video): void {
$action = new BackfillAudioAction($video);
$action->handle();